fix(ci): allow workflow_dispatch to trigger release#36
Conversation
The release job's if-condition required a merged PR with a release label, making workflow_dispatch always skip. Add event_name check so manual triggers work as a fallback when the PR path fails. Signed-off-by: Ben <ben@armosec.io>
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Free Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR adds ChangesRelease Workflow Trigger
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. Comment |
There was a problem hiding this comment.
Pull request overview
Updates the release workflow gating so the release job can be run manually via workflow_dispatch in addition to the existing “merged PR with release label” path, allowing a manual fallback when automation is skipped.
Changes:
- Extend the
releasejobifcondition to allowworkflow_dispatchtriggers. - Preserve the existing PR-merge +
releaselabel logic under a grouped condition.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| github.event_name == 'workflow_dispatch' || | ||
| (github.event.pull_request.merged == true && | ||
| contains(github.event.pull_request.labels.*.name, 'release') && | ||
| github.repository_owner == 'armosec') |
Summary
ifcondition required a merged PR with areleaselabel, makingworkflow_dispatchalways skipgithub.event_name == 'workflow_dispatch'so manual triggers work as a fallbackpull_request_targetevent actually fires (empty commits from PR chore: trigger v0.0.12 release #35 were silently skipped bypaths-ignore)Test plan
releaselabel → v0.0.12 release should completeSummary by CodeRabbit