Conversation
…ys_on is set The driver panics unconditionally when a power domain does not reach the requested idle or power state within the 10 ms handshake timeout. On some boards this kills the boot during early probe, before the dev_err naming the failing domain becomes visible on the console, and a later genpd power-off work can then get stuck on the PMU mutex. The tree already provides the opt-in "always_on" module parameter to skip power-off requests for bring-up. Let the two handshake panics honour it as well, so pm_domains.always_on=1 reports the failure through the existing dev_err paths and leaves the domain as-is instead of taking the machine down. The default behaviour is unchanged: without the parameter the panics stay in place. This is a bring-up aid for ELTAY RM66 (RK3566), which needs pm_domains.always_on=1 to reach userspace; the failing domain still needs a proper fix. Signed-off-by: Sergey Braumann <ripetitor@proton.me>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. WalkthroughThe change updates two error paths in the Rockchip power-domain driver. Both paths now suppress their panic calls when Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to With always-on mode enabled, the two handshake failures no longer panic while default behavior remains unchanged. The bounded change is ready to merge with normal checks. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
ELTAY RM66 (RK3566) doesn't boot the 6.1 BSP: pm_domains panics on the first handshake timeout during probe, before init, so the dev_err naming the failing domain is never printed.
The tree already has an opt-in always_on parameter that skips power-off, but both panics ignore it. Make them conditional on the same flag.
No change by default: without pm_domains.always_on=1 the panics stay. RM66 sets the flag in its board config and reaches userspace with it.
The failing domain still needs a real fix. This only keeps the board booting meanwhile.
Ref: armbian/build#10788