soc: rockchip: grf: Fix SDMMC not working on RK3588 with bus-width > 1 - #554
Conversation
Backport of upstream commit 6f6878e ("soc: rockchip: grf: Fix SDMMC not working on RK3588 with bus-width > 1", v6.6) to the rk35xx vendor 6.1 tree, which predates it. RK3588 SYS_GRF_SOC_CON6 bit 14 (force_jtag) resets to 1, muxing SDMMC D2/D3 to CPU JTAG whenever SDMMC_DETECTN is inactive, which prevents bus-width > 1 from working. Mainline clears this bit on nine Rockchip SoCs for the same reason; see the comment on rk3036_defaults in the same file. Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=6f6878ec6faf16a5f36761c93da6ea9cf09adb33 Signed-off-by: kevin.zhuang <kevin.zhuang@focalcrest.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. WalkthroughThe change defines Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The change correctly applies the RK3588 JTAG-switching default, with no unresolved merge-blocking risk identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Backports upstream
6f6878ec6faf(v6.6); this tree predates it.RK3588
SYS_GRF_SOC_CON6bit 14 (force_jtag) resets to 1 and muxes SDMMCD2/D3 to JTAG, so bus-width > 1 does not work.
This tree already carries the same "jtag switching" entry for rk3036, rk3128,
rk3228, rk3288, rk3328, rk3368 and rk3399 — RK3588 is simply missing it.
Not a verbatim copy of the upstream hunk: this tree's
rk3588_sys_grf_defaultsalready carries a vendor-specific"Connect EDP hpd to IO" entry, so the patch adds one line to the existing
array instead of introducing mainline's version of it.
Tested on Mixtile Core 3588E (Ubuntu 24.04, kernel 6.1.172-rockchip-vendor):
boots normally,
SYS_GRF_SOC_CON6reads0x000007c7(bit 14 = 0).