Anchor the HTTP/1 slowloris rate window at the first request byte#184
Merged
Conversation
The window was reset at keep-alive loop-back, so a reused connection idle past the grace had the idle gap counted as slow transmission and its next request silently dropped (502/503 behind connection-pooling proxies). Measure from the first received byte instead, excluding the idle wait.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A reused HTTP/1.1 keep-alive connection that idled past the 1s grace had the idle gap counted as slow transmission by the anti-Slowloris rate check, so its next request was silently dropped (502/503 behind connection-pooling proxies like nginx upstream keepalive or ngrok). The rate window now anchors at the first received byte of each request instead of at keep-alive loop-back, excluding the idle wait.