Implement github.create_issue MCP tool#3114
Conversation
- Add github.create_issue tool definition to MCP_TOOLS in definitions.ts - Implement createIssueHandler in src/tools/github.create_issue.ts using td-cli - Wire up the handler in server.ts - Add unit tests for the new handler in src/tools/github.create_issue.test.ts
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
🚀 Deployment Details (Last updated: Jun 27, 2026, 9:57 PM PST) 🚀 Pushed to gh-pages; publish in progress
|
- Implement github.create_issue MCP tool wrapping td-cli - Fix sys.path in td_cli.py to resolve tdw_services package - Update package.json audit:anti-patterns to include required PYTHONPATH - Add unit tests for github.create_issue handler
👁️ Gemini Code Review Agent
Reviewing: PR #3114 Code Review FeedbackGenerated by gemini-code-review |
🐙 GitHub Models Code Review
Reviewing: PR #3114 Model: gpt-4.1 Code Review Feedback[PERFORMANCE] ReviewNo HIGH / Blocking performance issues are present in this diff. All new code is straightforward, synchronous, and does not introduce expensive computations, redundant re-renders, or inefficient data structures. The handler is a thin wrapper around a CLI call, with proper input validation and error handling. There are no bundle or memory growth concerns. Detailed Review:
Test File: The tests are direct and do not introduce performance regressions. Summary: No blocking performance issues found. [STYLE] ReviewNo HIGH / Blocking issues found. All new code is type-safe, consistent with existing patterns, and readable. The handler validates input and output schemas, handles CLI errors, and parses responses robustly. The test file asserts correct behavior for both success and error cases. The tool is registered in the server switch with proper schema parsing. No design system/layout violations are possible in this backend/server-only code. Summary of review:
No blocking issues. Generated by github-models-code-review |
…issues - Implement github.create_issue MCP tool wrapping td-cli - Fix sys.path in td_cli.py to resolve tdw_services package without external PYTHONPATH - Update package.json audit:anti-patterns script to include required PYTHONPATH - Add comprehensive unit tests for github.create_issue handler in MCP server
- Implement github.create_issue MCP tool wrapping td-cli - Fix sys.path in td_cli.py to resolve tdw_services package without external PYTHONPATH - Update package.json audit:anti-patterns script to include required PYTHONPATH - Add comprehensive unit tests for github.create_issue handler in MCP server
arii
left a comment
There was a problem hiding this comment.
Comprehensive PR Review: #3114
Summary
This PR implements the github.create_issue MCP tool within the boomtick-mcp package. It correctly acts as a Tier 1 layer wrapping the Tier 2 td-cli gh create-issue command, utilizing Zod for robust input and output parsing.
Observations
- File Changes:
boomtick-pkg/mcp/src/mcp/definitions.ts: Adds thegithub.create_issueschema (Title, Body).boomtick-pkg/mcp/src/mcp/server.ts: Wires the tool directly to its new handler (createIssueHandler).boomtick-pkg/mcp/src/tools/github.create_issue.ts: Implements the handler, correctly callingrunCommand("td-cli", [...])and parsing the output string against a Zod schema.boomtick-pkg/mcp/src/tools/github.create_issue.test.ts: Complete unit tests mocking the CLI shell wrapper.td_cli.py: Adjustssys.path.appendlogic to ensure both CLI root anddev_toolsare available, fixing implicit import errors.package.json: Prefixes theaudit:anti-patternsscript withPYTHONPATHexports so the anti-pattern script runs properly locally.
- Adherence to Repository Standards: The new MCP tool perfectly aligns with memory constraints: it uses
runCommand("td-cli", ["gh", ...])instead of rawghbinaries, and it validates CLI inputs/outputs usingZod. - CI Status: The PR passes all validation (
deploy,build,resolve-conflicts,verify-changes, etc.).
Recommendations
- The implementation is clean and completes the
github.create_issuefeature request robustly. The addition of Python path bootstrapping intd_cli.pymakes it far more resilient.
Conclusion
Excellent addition to the MCP server. The tool is fully compliant with repository constraints. Ready for merge.
- Implement github.create_issue MCP tool wrapping td-cli - Fix sys.path in td_cli.py to resolve tdw_services package without external PYTHONPATH - Update package.json audit:anti-patterns script to include required PYTHONPATH - Add comprehensive unit tests for github.create_issue handler in MCP server
arii
left a comment
There was a problem hiding this comment.
PR Review: #3114 - Implement github.create_issue MCP tool
Context Analysis:
This PR titled "Implement github.create_issue MCP tool" modifies the following files: boomtick-pkg/cli/dev_tools/td_cli.py, boomtick-pkg/mcp/src/mcp/definitions.ts, boomtick-pkg/mcp/src/mcp/server.ts, boomtick-pkg/mcp/src/tools/github.create_issue.test.ts, boomtick-pkg/mcp/src/tools/github.create_issue.ts, package.json.
The PR has been automatically fetched and its context analyzed.
File-specific Feedback:
- Looking at
boomtick-pkg/cli/dev_tools/td_cli.py, the modifications appear structurally sound based on the diff context provided. - The CI checks logged in the context show that foundational gates and build processes have been executed.
- Please verify that any changes to
boomtick-pkg/cli/dev_tools/td_cli.pydo not introduce unintended side effects in downstream consumers, especially if this is a configuration or dependency file.
Recommendation:
Based on the automated audit and CI status, this PR is progressing normally. The changes to boomtick-pkg/cli/dev_tools/td_cli.py are consistent with the PR description. If all tests pass and there are no overlapping conflict risks as identified in the global overlap report, it is recommended to proceed with merging.
Remaining work:
Verify that the changes to boomtick-pkg/cli/dev_tools/td_cli.py, boomtick-pkg/mcp/src/mcp/definitions.ts, boomtick-pkg/mcp/src/mcp/server.ts, boomtick-pkg/mcp/src/tools/github.create_issue.test.ts, boomtick-pkg/mcp/src/tools/github.create_issue.ts, package.json perform as expected in the deployed environment. No major anti-patterns were detected in the immediate diff.
Implemented the
github.create_issueMCP tool in theboomtick-mcpserver. This tool allows for programmatic issue creation by wrapping thetd-cli gh create-issuecommand.Key changes:
github.create_issuetool schema inboomtick-pkg/mcp/src/mcp/definitions.ts.boomtick-pkg/mcp/src/tools/github.create_issue.ts, including input validation and CLI response parsing.boomtick-pkg/mcp/src/mcp/server.ts.boomtick-pkg/mcp/src/tools/github.create_issue.test.tsand verified that all MCP tests pass.Fixes #3101
PR created automatically by Jules for task 3985094494030064141 started by @arii