Skip to content

Health Monitor Improvements#259

Open
lowpolyneko wants to merge 16 commits into
argonne-lcf:mainfrom
lowpolyneko:health-monitor-improvements
Open

Health Monitor Improvements#259
lowpolyneko wants to merge 16 commits into
argonne-lcf:mainfrom
lowpolyneko:health-monitor-improvements

Conversation

@lowpolyneko

@lowpolyneko lowpolyneko commented Jun 15, 2026

Copy link
Copy Markdown
Member

This PR performs a general restructuring of the health monitor script to improve type checking and general readability.

Fixes LCF-115.

@lowpolyneko lowpolyneko self-assigned this Jun 15, 2026
@lowpolyneko lowpolyneko force-pushed the health-monitor-improvements branch 5 times, most recently from 9973999 to a59ea10 Compare June 16, 2026 21:26
@lowpolyneko lowpolyneko requested a review from masalim2 June 16, 2026 21:33
@lowpolyneko lowpolyneko added the enhancement New feature or request label Jun 16, 2026
@lowpolyneko lowpolyneko marked this pull request as ready for review June 16, 2026 21:33
@masalim2

Copy link
Copy Markdown
Member

Looks great! Let's deploy this cron job to production as a sanity check, since it shouldn't impact anything user-facing.

@lowpolyneko

Copy link
Copy Markdown
Member Author

Agreed. Production is actually already running an earlier revision of the refactored cronjob prior to me cleaning the commit log of this branch and making some last minute adjustments. So, aslong as a regression doesn't appear after I deploy the finalized PR, it should be save to merge after some monitoring.

@lowpolyneko lowpolyneko force-pushed the health-monitor-improvements branch from 666d429 to 59755f8 Compare June 17, 2026 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants