Skip to content

Fix timezone#51

Open
yihuang wants to merge 1 commit into
areski:developfrom
yihuang:develop
Open

Fix timezone#51
yihuang wants to merge 1 commit into
areski:developfrom
yihuang:develop

Conversation

@yihuang

@yihuang yihuang commented Sep 19, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@areski

areski commented Sep 20, 2019

Copy link
Copy Markdown
Owner

Hi,

Could you give some context here? It seems you are fixing timezone but also adding a user model, why ?

@yihuang

yihuang commented Sep 20, 2019

Copy link
Copy Markdown
Contributor Author

Sorry for the confusion, the user field is for my use case.
I want non-superuser can only view his own data. I think the change is backward compatible.

@areski

areski commented Sep 21, 2019

Copy link
Copy Markdown
Owner

@PetrDlouhy your opinion on this will be appreciated :) ?

@PetrDlouhy

Copy link
Copy Markdown
Contributor

I am still confused what is this PR about.

@yihuang Can You please change this PR to include only changes related to single issue (and move the other changes to separate PR if needed) and change the title and description accordingly?

@yihuang

yihuang commented Sep 24, 2019

Copy link
Copy Markdown
Contributor Author

@PetrDlouhy OK, Just done that ;D

@PetrDlouhy

Copy link
Copy Markdown
Contributor

@yihuang Why is there the jquery fix? I am not sure what it fixes, and discussion about that should be part of another PR.

@yihuang

yihuang commented Oct 3, 2019

Copy link
Copy Markdown
Contributor Author

@PetrDlouhy I though django's jquery only expose window.jQuery, but I'm not sure now, so I'm revering this commit for the pull request now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants