Skip to content

Implement the Wire.flush() funtion#773

Open
watershade wants to merge 1 commit into
arduino:mainfrom
watershade:wire_flush_implement
Open

Implement the Wire.flush() funtion#773
watershade wants to merge 1 commit into
arduino:mainfrom
watershade:wire_flush_implement

Conversation

@watershade

Copy link
Copy Markdown
  1. implement flush of wire. (flush functions have never been implemented before. But it is useful.)

1. implement flush of wire.
(flush functions have never been implemented before. But it is useful.)
@watershade

Copy link
Copy Markdown
Author

Wire.flush() is useful, if I haven't read obsolete data from it. I will get a wrong number via Wire.available() because the size have include the obsolete data. And If I use Wire.read(), the data I read out is include the obsolete data also. Yes, I can read the obsolete data out via Wire.read(), but it is not necessary. If Wire.flush() is I implemented, It will become perfect.
Thanks!

@watershade

Copy link
Copy Markdown
Author

@facchinm Hi Martino, I don't know if you time to check this merge. Thanks.

@tokiedokie

Copy link
Copy Markdown
Contributor

Duplicate of #760

@pennam pennam mentioned this pull request Feb 1, 2024
@pennam

pennam commented Feb 1, 2024

Copy link
Copy Markdown
Contributor

Flush should be intended as a way to send all data out of the TX buffer not to cleanup the RX. See Serial.flush() https://www.arduino.cc/reference/it/language/functions/communication/serial/flush/

@tokiedokie

Copy link
Copy Markdown
Contributor

Should the RX buffer cleanup API be called clear()?

@pennam

pennam commented Feb 1, 2024

Copy link
Copy Markdown
Contributor

Should the RX buffer cleanup API be called clear()?

I don't think there is a standard Arduino API, but personally i think is a more appropriate name.

@watershade

watershade commented Feb 3, 2024

Copy link
Copy Markdown
Author

@pennam Thanks for your reply.

I remember flush really flush all data away in old Arduino version.

Prior to Arduino 1.0, this instead removed any buffered incoming serial data.

I will check the new version and try to find a better name. Maybe clear and it is just like @tokiedokie have said .

Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants