Introduce async NTP methods#241
Open
makise-homura wants to merge 3 commits into
Open
Conversation
|
|
|
Memory usage change @ aca4ce6
Click for full report table
Click for full report CSV |
per1234
added
type: enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Waiting for a response to NTP query might be a time-consuming operation, so it is not perfect that
forceUpdate()blocks in this case.I've implemented
startUpdate()andfinishUpdate()methods that may be useful to process a response once it is received, not block while waiting for it.An example is added too to show how to use these methods,
Async.ino.