Add handling for NTP server returning 0#211
Open
Der-Schubi wants to merge 3 commits into
Open
Conversation
Fixes arduino-libraries#193, fixes 84, fixes Credits to @frankB415 for the Code in Issue arduino-libraries#193!
|
|
|
Memory usage change @ 841c965
Click for full report table
Click for full report CSV |
|
Any plans to merge this PR ? It's needed in many places. |
flattermann
added a commit
to flattermann/info-orbs
that referenced
this pull request
Mar 4, 2025
flattermann
added a commit
to flattermann/info-orbs
that referenced
this pull request
Mar 4, 2025
|
Memory usage change @ 59623e2
Click for full report table
Click for full report CSV |
|
Memory usage change @ da4ed49
Click for full report table
Click for full report CSV |
|
I tested the code in this submission and found a bug. In the event that the NTP server returns a zero epoch, _lastupdate is modified, but _currentepoch is not. This then causes an error in value returned by the getEpochTime() method. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #193, fixes #84
Credits to @frankB415 for the Code in Issue #193!