Fix wasm unaligned load/store paths#96
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
load_unaligned/store_unalignedimplementations across all numeric SIMD types with explicitv128_load/v128_storeintrinsicsi8,i16,i32,i64,f32, andf64Why
The audit found that the wasm "unaligned" paths were implemented as raw typed
v128pointer dereferences/stores. That is exactly the pattern we did not want for an unaligned API: it relies on typed pointer deref semantics instead of the explicit wasm load/store intrinsics intended for this job.This PR makes the unaligned paths honest without changing the aligned ones.
Validation
Host-side:
cargo fmt --allcargo clippy --all --all-targets -- --deny warningscargo testWasm-side:
RUSTFLAGS='-C target-feature=+simd128' cargo check --lib --target wasm32-unknown-unknownNote: a full
cargo test --target wasm32-unknown-unknownbuild is currently blocked by unrelated dev-dependency/tooling issues (getrandomin the test/bench stack for that target), so local wasm validation here is compile-only at the library level. The PR still adds wasm-only regression tests for the intended misaligned roundtrip behavior.