Skip to content

ci: format the workspace with cargo fmt and check it in CI - #230

Merged
davidmytton merged 1 commit into
mainfrom
rei/fix/ENG-1379-cargo-fmt
Oct 3, 2026
Merged

davidmytton merged 1 commit into
mainfrom
rei/fix/ENG-1379-cargo-fmt

Conversation

@arcjet-rei

Copy link
Copy Markdown
Contributor

AGENTS.md asks for cargo fmt before committing, but CI never checked it, and cargo fmt --check reported 12 unformatted hunks on main. This formats the workspace once and adds a cargo fmt --all --check step before the build in the Gravity tests job, using the rustfmt from the pinned toolchain. It changes formatting only; generated output and test results are unchanged.

Merge this after the open pull requests that touch the same files. Running cargo fmt --all after rebasing regenerates it.

🤖 Generated with Claude Code

AGENTS.md asks for cargo fmt before committing, but CI never checked it,
and cargo fmt --check reported 12 unformatted hunks on main across
exports.rs, func.rs, imports.rs and the regressions example. Format the
workspace once and run cargo fmt --all --check before the build in the
Gravity tests job, with the rustfmt from the pinned toolchain.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@arcjet-rei
arcjet-rei requested a review from a team as a code owner October 3, 2026 02:16

@arcjet-review arcjet-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arcjet Review — 🟡 Medium Risk

Decision: Checked

Rationale: This PR makes a small CI workflow change by adding cargo fmt --all --check before the build, and the Rust source changes shown are formatting-only import ordering and line wrapping. The CI/CD escalation trigger fires because .github/workflows/ci.yml changed, but the change is narrow, uses the existing Cargo toolchain, does not introduce secrets or untrusted input handling, and does not alter application logic. I am approving despite Medium risk because the workflow modification is straightforward and the code changes are mechanical formatting updates.

Summary of Changes

Adds a CI cargo fmt --all --check step to the Gravity tests workflow and checks in rustfmt-produced formatting changes across several Rust files.

Escalation Triggers

  • CI/CD Pipeline: The PR modifies .github/workflows/ci.yml by adding a new cargo fmt check step.

Review Focus Areas

Notes

The AI assessed this PR as approvable, but the trust level (1) does not allow auto-approval. A human reviewer must approve this PR.

Review: 360567c4 | Model: openai/gpt-5.5 | Powered by Arcjet Review

@arcjet-review arcjet-review Bot removed the needs review Awaiting human review label Oct 3, 2026
@davidmytton
davidmytton merged commit ebe87a4 into main Oct 3, 2026
4 checks passed
@davidmytton
davidmytton deleted the rei/fix/ENG-1379-cargo-fmt branch October 3, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants