Skip to content

fix: declare root package for pnpm 9 workspace compatibility - #28

Merged
archcorsair merged 1 commit into
masterfrom
fix/pnpm9-workspace-root
Oct 22, 2026
Merged

archcorsair merged 1 commit into
masterfrom
fix/pnpm9-workspace-root

Conversation

@archcorsair

Copy link
Copy Markdown
Owner

CI fails during setup-node's pnpm cache lookup because pnpm 9.15.9 rejects pnpm-workspace.yaml without a packages field. Declare . as the workspace package while preserving the existing esbuild onlyBuiltDependencies setting. Only pnpm-workspace.yaml changes; dependencies and the lockfile are unchanged.

Validation:

  • The original YAML reproduces the error in pnpm 9.15.9's upstream packages validator; the changed YAML passes the same validator. This is a source-level check, not a full CLI reproduction.
  • git diff --check passes.
  • Full install, lint, tests, and build remain unverified locally: the environment proxy returns HTTP 503 ("VPN is not configured") when fetching pnpm and dependencies. The script attempts could not run because eslint, vitest, and tsup were unavailable.

GitHub CI should provide the full validation before merge.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-22T04:41:07.488166Z 33a396e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@archcorsair
archcorsair merged commit e894b75 into master Oct 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant