dsp: optimize fixed half-band SIMD kernels#246
Merged
Conversation
Signed-off-by: arancormonk <180709949+arancormonk@users.noreply.github.com>
Signed-off-by: arancormonk <180709949+arancormonk@users.noreply.github.com>
arancormonk
marked this pull request as ready for review
July 17, 2026 03:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The 1.536 MS/s to 48 kHz RTL path uses one 31-tap stage followed by four 15-tap stages. The generic SIMD kernels copied the full interleaved input into scratch storage and scalar-packed decimated complex samples before doing relatively little half-band arithmetic. Fixed-size kernels can instead load alternating complex samples directly and fully unroll the side taps while retaining the existing phase, output sizing, history layout, and edge behavior.
Performance
Five-repeat median comparisons on the x86 host:
Instruction counts fell by roughly 75% for AVX2 and 67–68% for SSE2 in the targeted cases. No unrelated DSP benchmark exceeded the 5% regression threshold. NEON timing is intentionally omitted because emulation is not representative of physical ARM performance.
Validation
ctest --preset dev-debug --output-on-failure: 460/460 passedtools/preflight_ci.sh: passedPhysical NEON hardware timing and the live RTL/P25 capture run remain to be confirmed on suitable hardware.