Skip to content

chore: add schema id #10969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vessel9817 wants to merge 3 commits into
base: main
Choose a base branch
from
+2 −0
Open

chore: add schema id #10969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f46418e
Added schema ID
Vessel9817 Jul 15, 2026
ba75992
Revert "Added schema ID"
Vessel9817 Jul 16, 2026
4a3976c
Added ID to schema generator
Vessel9817 Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions magefiles/config_schema.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ const configSchemaPath = "schema/trivy-config.json"
func generateConfigSchema(outputPath string, allFlagGroups []flag.FlagGroup) error {
root := &jsonschema.Schema{
Schema: "https://json-schema.org/draft/2020-12/schema",
ID: "https://www.schemastore.org/trivy-config.json",
Type: schemaTypeObject,
Title: "Trivy Configuration",
Description: "Configuration file for Trivy security scanner (trivy.yaml)",
Expand Down
1 change: 1 addition & 0 deletions schema/trivy-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -928,6 +928,7 @@
}
}
},
"$id": "https://www.schemastore.org/trivy-config.json",

@DmitriyLewen DmitriyLewen Jul 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We generate this file using generateConfigSchema() (in mage package).
You need to update this function.

@DmitriyLewen DmitriyLewen Jul 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this PR hasn't been merged yet, I think we can wait a bit.
If they don't merge it, we'll change the URL to https://raw.githubusercontent.com/aquasecurity/trivy/main/schema/trivy-config.json.

@Vessel9817 Vessel9817 Jul 17, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just been merged, should be up on the website later

"$schema": "https://json-schema.org/draft/2020-12/schema",
"title": "Trivy Configuration",
"description": "Configuration file for Trivy security scanner (trivy.yaml)"
Expand Down