fix(image): merge OS data from cached layers#10968
Open
1solomonwakhungu wants to merge 1 commit into
Open
Conversation
Closes aquasecurity#9982 Read OS information from every cached image layer before running config analyzers, and merge parallel results in deterministic layer order. Add a cache RPC for client/server scans and fall back to layer analysis when cached OS data cannot be read. Signed-off-by: Solomon Wakhungu <65043605+1solomonwakhungu@users.noreply.github.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Image config analysis previously merged OS data only from layers analyzed during the current scan. If a layer was already cached, its OS data was omitted; when several layers were analyzed in parallel, completion order could also affect the merged result.
This change:
Related issues
inspectConfig, the OS information obtained from the layers is non-deterministic or missed #9982Type of Change
Testing
GOEXPERIMENT=jsonv2 go test ./...go tool mage test:unitGOEXPERIMENT=jsonv2 go test -race ./pkg/fanal/artifact/image -run TestArtifact_InspectUsesCachedOSInLayerOrderGOEXPERIMENT=jsonv2 golangci-lint run --build-tags=integration --new-from-rev=upstream/maingo tool mage protoc:breakingThe regression test forces cached layer lookups to finish out of order and verifies that config analysis still receives the OS produced by image layer order.
Checklist