feat(nodejs): detect Node.js runtime version from header#10951
Open
jetersen wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
This has useful to have access after a trivy scan besides for vulns but the ability to tell which image is using what nodejs version is a good diagnostic tool. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature discussion
Description
Detect the installed Node.js runtime version from the standard
include/node/node_version.hheader. The analyzer readsNODE_MAJOR_VERSION,NODE_MINOR_VERSION, andNODE_PATCH_VERSION, then emitsnode@<version>alongside other Node.js packages.This covers manually installed runtimes such as the official Node.js container image, where no
apk,dpkg, orrpmpackage metadata identifies the runtime.Runtime CVE advisories are added by the companion trivy-db PR:
Both changes are required for runtime CVE reporting: this PR supplies the installed version; trivy-db supplies vulnerable and patched version ranges.
Verification
Official
node:latest:Testing
GOEXPERIMENT=jsonv2 go test ./pkg/fanal/analyzer/language/nodejs/pkgnode:latestgit diff --checkNotes
Image
NODE_VERSIONenvironment-variable fallback is intentionally not included; the standard installed header is used as the authoritative source.Maintainer decision requested
The companion trivy-db importer has intentionally skipped Node.js core advisories since 2019. trivy-db PR #683 is therefore a deliberate behavior change, not merely wiring previously unused data. Pending confirmation that runtime CVE reporting—and use of package
nodein the npm ecosystem—is the desired model.