fix(releases): split fullnode vs validator-set node versions#1610
Draft
gregnazario wants to merge 3 commits into
Draft
fix(releases): split fullnode vs validator-set node versions#1610gregnazario wants to merge 3 commits into
gregnazario wants to merge 3 commits into
Conversation
✅ Deploy Preview for aptos-explorer ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…rk cards Fullnode git_hash stays tied to the configured REST gateway; validator-set hash is sampled from ValidatorSet advertised hostnames with GitHub release resolution for both rows when hashes exist. Co-authored-by: Greg Nazario <greg@gnazar.io>
gregnazario
force-pushed
the
cursor/fullnode-vs-validator-git-hash-e8d1
branch
from
e84ea39 to
2b183ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Network cards on
/releases/networkspreviously showed a single Node Release / Node Commit pair sourced fromGET …/v1/on the configured Aptos REST URL. Thatgit_hashreflects the gateway fullnode, not active validators.This change:
fullnodeGitHash, still exposed asgitHashfor backward compatibility).ValidatorSet: extract DNS hostnames fromnetwork_addresses/fullnode_addressesblobs for the first validators, probe common REST URL shapes (https://host/v1,http://host:8080/v1,http://host:8180/v1), take the mode among successfulgit_hashresponses, and resolve both rows via the existing GitHub commit-message parser.Operator endpoints may be unreachable from browsers (firewall, TLS, non-standard ports, or CORS). In those cases the validator rows stay empty rather than reusing the gateway hash; tooltips explain the sampling.
Tests / verification
app/utils/aptosValidatorAdvertisedHosts.test.ts(hostname extraction, hash normalization, mode).useGetNetworkStatus.test.tswith a probe mock.CI initially failed Biome on
aptosValidatorAdvertisedHosts.ts(non-null assertions, assignment-in-while). Follow-up commit fixes those.Docs
docs/FEATURES_SPECIFICATION.md(FEAT-RELEASES-001),CHANGELOG.md,public/llms.txt, andpublic/llms-full.txt.["deployments","networkStatus","v2",network]and increased stale time to 5 minutes to reduce repeated third-party probing.