Conversation
Greptile SummaryThis PR updates the Swift SDK to version 19.1.0, adding new API features and fixing a header injection issue in the client. The core architectural change moves
Confidence Score: 4/5Safe to merge; the header refactoring is broad but consistent across all service files, and the URL fix is clearly correct. The main architectural change — moving X-Appwrite-Project out of setProject()'s global addHeader and into each service call's explicit headers — is correctly applied across every service method in the diff. Other credential setters (setKey, setJWT, setLocale, setSession) still use addHeader, leaving a small inconsistency in the client API surface that is worth being aware of but does not affect runtime correctness. Sources/Appwrite/Client.swift deserves a second look due to the project-header architecture change. Important Files Changed
Reviews (1): Last reviewed commit: "chore: update Swift SDK to 19.1.0" | Re-trigger Greptile |
| open func setProject(_ value: String) -> Client { | ||
| config["project"] = value | ||
| _ = addHeader(key: "X-Appwrite-Project", value: value) | ||
| return self | ||
| } |
There was a problem hiding this comment.
Inconsistency between
setProject and other credential setters
setKey, setJWT, setLocale, and setSession still call addHeader to inject their values as global headers on every request, but setProject no longer does — it only stores the value in config. The project ID is now injected per-call at the service layer. Any caller that uses client.call(...) directly (bypassing the service classes), or any future service method that forgets to include "X-Appwrite-Project", will silently omit the header.
This PR contains updates to the Swift SDK for version 19.1.0.
What's Changed
createSesProviderandupdateSesProvidertomessagingupdateOAuth2Servertoprojectfor OAuth2 server settingsupdatePasswordStrengthPolicyandPolicyPasswordStrengthtoprojectgetAuditsDBhealth check tohealthpassword-strengthtoProjectPolicyIdapps.readandapps.writetoProjectKeyScopes