Restore component v3 ApiService rendering behavior#142
Merged
Conversation
…urces This restores component version v3 behavior for `ApiService` rendering. Currently on a vcluster with K8s version 1.25, the ArgoCD app is permanently out of sync due to the presence of `spec.insecureSkipTLSVerify=false` in the `ApiService` manifests in the GitOps repo. Most likely, we can drop this commit once we upgrade the control-api vclusters to a more recent K8s version.
|
🚀 This PR has been released as Triggering workflows 🛠️ Auto tagging enabled with label |
DebakelOrakel
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans up the Kustomization rendering by using
std.manifestJsonMinified()to generate JSON patches instead ofstd.format()+ multi-line strings.Additionally, we adjust the behavior of the
ApiServicepatch to not emitspec.insecureSkipTLSVerify=false(note that this may not be necessary on recent K8s -- however, we have issues with ArgoCD on K8s 1.25 when this field is present and set to false).Finally, we also adjust the
ApiServicepatch to not setspec.caBundle=nullwhen an empty CA certificate string is configured.Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.