Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📎 관련 Issue 번호
📄 작업 내용 요약
용어 삭제 관련 이벤트 처리 방식을 테스트하는 케이스는 이미 존재했으나
엄밀히 따지면 해당 이벤트 리스너에 트랜잭션이 정확히 있는지 여부를 확인하는 정도의 테스트였습니다
이는 기능을 확장했을 때 트랜잭션을 누락하는 경우 정상적으로 이를 캐치할 수 없으므로
외부 트랜잭션의 유무 및 이벤트 처리 성공 / 실패에 따라 상태를 직접 확인하는 통합 테스트를 추가했습니다
🙋🏻 주의 깊게 확인해야 하는 코드
📄 개선 사항 OR 참고 사항