Skip to content

Fix NPE #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lmartelli wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix NPE #866

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion approvaltests/src/main/java/org/approvaltests/reporters/GenericDiffReporter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public GenericDiffReporter(String diffProgram, String argumentsFormat, String di
this.diffProgram = diffProgram;
this.arguments = argumentsFormat;
this.diffProgramNotFoundMessage = diffProgramNotFoundMessage;
validExtensions = validFileExtensions;
this.validExtensions = validFileExtensions;

@sourcery-ai sourcery-ai Bot Sep 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): The change is behaviorally identical to the removed assignment and does not prevent validExtensions from remaining null. When validFileExtensions is null—as permitted by the four-argument constructor and used by existing tests—isFileExtensionHandled passes null to isFileExtensionValid, whose contains call raises the reported NullPointerException.

Triggers: When a reporter is constructed with a null extension list.

Suggested fix: Default null extension lists to an empty list or handle null in isFileExtensionHandled/isFileExtensionValid.

Suggested change
this.validExtensions = validFileExtensions;
this.validExtensions = validFileExtensions == null ? new ArrayList<String>() : validFileExtensions;

}

public GenericDiffReporter(DiffInfo info)
Expand Down