Add installation message signing quickstart hooks#2
Open
charlesoj6205 wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Shapes quickstart app to include hooks for Approov installation message signing and improves visibility into Shapes API responses during debugging, alongside an Approov SDK version bump.
Changes:
- Bump
approov-service-nsurlsessionCocoaPods dependency from3.5.3to3.5.4. - Add commented “installation message signing” hooks (v5 endpoint + message signing mode setter).
- Add more detailed logging for Shapes responses to help diagnose Approov/message-signing related failures.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| shapes-app/ApproovShapes/Podfile | Updates Approov CocoaPods dependency version to pick up the SDK changes needed for the quickstart hooks. |
| shapes-app/ApproovShapes/ApproovShapes/ViewController.m | Adds message-signing quickstart toggle points and expands response logging to aid troubleshooting. |
Comments suppressed due to low confidence (1)
shapes-app/ApproovShapes/ApproovShapes/ViewController.m:160
- This declares a new local
NSError* errorthat shadows theNSError *errorparameter of the completion handler, making the code harder to follow. Rename the JSON parsing error to a distinct variable (e.g.,jsonError).
NSError* error;
NSDictionary* jsonDict = [NSJSONSerialization JSONObjectWithData:data options:NSJSONReadingMutableContainers error:&error];
if (error != nil) {
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+135
to
+139
| // Log the full Shapes response so Approov/message-signing failures are visible in Xcode. | ||
| NSString* responseBody = @"<empty>"; | ||
| if (data != nil && data.length > 0) { | ||
| responseBody = [[NSString alloc] initWithData:data encoding:NSUTF8StringEncoding]; | ||
| if (responseBody == nil) |
There was a problem hiding this comment.
Fixed in a592146: the detailed response logging is now wrapped in #ifdef DEBUG so it only runs in debug builds, and the redundant NSLog(@"Data: %@", responseBody) in the 200-path has been removed.
…ndant log Agent-Logs-Url: https://github.com/approov/quickstart-ios-objectivec-nsurlsession/sessions/66fe19b3-e679-4a01-b74e-e62316fbc9e5 Co-authored-by: charlesoj6205 <272465118+charlesoj6205@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.