fix: regenerate with latest cli & remove reset scanner function#7
Open
amaanq wants to merge 2 commits into
Open
fix: regenerate with latest cli & remove reset scanner function#7amaanq wants to merge 2 commits into
amaanq wants to merge 2 commits into
Conversation
holzensp
requested changes
May 20, 2024
holzensp
left a comment
holzensp
left a comment
Collaborator
There was a problem hiding this comment.
This had somehow gone in under my radar. Sorry for the slow reply and thanks for the contribution. There are 10 errors in CI that should reproduce when you run npm test:
errors/delimiters/missingFunction0ParameterListDelimitererrors/delimiters/missingFunctionTypeParameterListSeparatorerrors/delimiters/missingIfExprDelimitererrors/delimiters/missingListDelimitererrors/delimiters/missingMapDelimitererrors/delimiters/missingMethodArgumentListDelimitererrors/delimiters/missingParenthesizedExprDelimitererrors/delimiters/missingSubscriptDelimitererrors/delimiters/unbalancedEntryBrackets1errors/delimiters/unbalancedEntryBrackets3
These seem related to the removed conflicts. I'll try and dive in deeper later on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also the conflicts were unnecessary - and the test corpus files should be under
test