Remove @Sendable and @escaping restrictions from condition(:_), timeout(for:body:) and withCancellationShield(_:)#148
Open
bauer-andreas wants to merge 3 commits into
Open
Conversation
…hCancellationShield(_:)`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the methods
condition(:_),timeout(for:body:)andwithCancellationShield(_:)require the closure they accept to be@escapingor@Sendable/sending. None of these requirements are actually true.The closure getting passed to these methods never actually escape the call context. Secondly, because we know everything is executed on the Workflow serial executor, we can also remove the
@Sendableandsendingrequirements as (each of these closures arenonisolated(nonsending)by default now).Modifications
@Sendable @escapingrequirement from the timeout closure.@escapingrequirement for the workflow condition closure.sending @escapingrequirement from the cancellation shield.Test Plan
N/A