Documentation for fieldmask utilities#1693
Merged
Merged
Conversation
tbkka
approved these changes
Aug 19, 2024
tbkka
left a comment
tbkka
left a comment
Collaborator
There was a problem hiding this comment.
This is pretty well written overall. I've marked a few places where I think it could be shortened. I've also noted one place where I think expanding an example would help make things clearer.
Collaborator
|
fyi - once the docs are in, I'll look at doing a release to get this and the access levels work out. |
Contributor
Author
|
All comments were fixed. Please check again @tbkka |
tbkka
reviewed
Aug 23, 2024
tbkka
reviewed
Aug 23, 2024
tbkka
reviewed
Aug 23, 2024
tbkka
approved these changes
Aug 23, 2024
tbkka
left a comment
tbkka
left a comment
Collaborator
There was a problem hiding this comment.
This is great! I'm happy to merge it as-is, though I did find a couple of very minor wording improvements that you could use if you want.
Collaborator
|
Thanks for all the hard work here. I'm thrilled to get this out! |
Contributor
Author
|
It was my pleasure! I'm just as excited to see it out there! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds documentation for field mask utilities added in #1505