agnostivdev/StreamMetadata: Make QUICStreamMetadata a non-copyable struct#14
Open
agnosticdev wants to merge 1 commit into
Open
agnostivdev/StreamMetadata: Make QUICStreamMetadata a non-copyable struct#14agnosticdev wants to merge 1 commit into
agnosticdev wants to merge 1 commit into
Conversation
agnosticdev
requested review from
ekinnear,
kkuk24,
rpaulo and
tfpauly
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a performance change to reduce the amount of reference types allocated when creating a high volume of QUIC streams. This will be particularly noticeable on the server side when QUIC is servicing a high volume of streams.
I did some other independent CPU analysis and this change also reduces the CPU load when dealing with high volume stream use cases.