Skip to content

Better explain aggregate flag#223

Merged
kukushechkin merged 4 commits into
apple:mainfrom
kukushechkin:explain-aggregate
May 7, 2026
Merged

Better explain aggregate flag#223
kukushechkin merged 4 commits into
apple:mainfrom
kukushechkin:explain-aggregate

Conversation

@kukushechkin

Copy link
Copy Markdown
Contributor

Expand aggregate flag explanation.

Closing #98

@kukushechkin kukushechkin requested a review from heckj May 7, 2026 12:11
@kukushechkin kukushechkin added the semver/none No version bump required. label May 7, 2026

@heckj heckj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our style guidelines for technical docs generally prefers that we prefix with "A Boolean value that indicates" if we're not speaking directly to what the property represents, but I totally get the implied "Whether" means "Boolean value" and am fine with that if you prefer it for the way it reads.

Comment thread Sources/CoreMetrics/Metrics.swift Outdated
Comment thread Sources/CoreMetrics/Metrics.swift Outdated
Comment thread Sources/CoreMetrics/Metrics.swift Outdated
Comment thread Sources/CoreMetrics/Metrics.swift Outdated
kukushechkin and others added 2 commits May 7, 2026 16:19
@kukushechkin kukushechkin enabled auto-merge (squash) May 7, 2026 15:33
@kukushechkin kukushechkin merged commit 4356830 into apple:main May 7, 2026
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver/none No version bump required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants