Correctly forward multiplexed instruments to factories upon destruction#222
Merged
kukushechkin merged 1 commit intoMay 7, 2026
Merged
Conversation
FranzBusch
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correctly forward multiplexed instruments to factories upon destruction.
Motivation:
Factories inside
MultiplexMetricsHandlerreceiveMuxXXXinstruments instead of instruments they created during destruction. They have no idea what to do with them. For exampleswift-otelsilently drops such an unknown instrument without destroying it.Modifications:
Forward underlying instruments to the corresponding factories.
Result:
Multiplexed instruments can be correctly destroyed by their factories.