This repository was archived by the owner on Apr 2, 2020. It is now read-only.
[SwiftExpressionParser] Remove a bunch of hacks in the handling of `s…#1789
Open
dcci wants to merge 1 commit into
Open
[SwiftExpressionParser] Remove a bunch of hacks in the handling of `s…#1789dcci wants to merge 1 commit into
dcci wants to merge 1 commit into
Conversation
…elf`. Presumably there was a time where these were needed, but this is not true anymore. I'm mainly motivated by the fact that every time I stop in the expression parser hitting all this dead code I lose focus, but this is generally good for readability and maintanability in general.
Contributor
Author
|
@swift-ci test and merge |
compnerd
approved these changes
Jul 11, 2019
| @@ -550,52 +541,11 @@ AddRequiredAliases(Block *block, lldb::StackFrameSP &stack_frame_sp, | |||
| swift_runtime->DoArchetypeBindingForType(*stack_frame, | |||
| imported_self_type); | |||
Collaborator
There was a problem hiding this comment.
Since we overwrite imported_self_type, might be a good thing to assert that the archtetype binding succeeded (assert(imported_type_type.isValid());)
Member
|
@swift-ci test and merge |
slavapestov
approved these changes
Jul 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…elf`.
Presumably there was a time where these were needed, but this is not true
anymore. I'm mainly motivated by the fact that every time I stop in
the expression parser hitting all this dead code I lose focus, but
this is generally good for readability and maintanability in general.