Check state again after connecting to ensure we don't resurrect a dead session#99
Open
hamzahrmalik wants to merge 1 commit into
Open
Check state again after connecting to ensure we don't resurrect a dead session#99hamzahrmalik wants to merge 1 commit into
hamzahrmalik wants to merge 1 commit into
Conversation
…d session if session was shut down during the connect, we unconditionally set it back to state connected again, rather than keeping it disconnected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently, if session was shut down during the connect, we unconditionally set it back to state connected again, rather than keeping it disconnected
We should instead check the current state again to make sure we don't resurrect a dead connection and mark it as connected.
Added a test which would've hit the fatalError in CassandraClient/deinit without the changes in this commit