bugfix: Fix enum case generation for uppercase string-literal values#160
Open
myaumura wants to merge 2 commits into
Open
bugfix: Fix enum case generation for uppercase string-literal values#160myaumura wants to merge 2 commits into
myaumura wants to merge 2 commits into
Conversation
bioball
approved these changes
Jun 8, 2026
Comment on lines
+46
to
+47
| // Colliding normalized names (e.g. "beetle one"/"beetle_one") are disambiguated | ||
| // with a numeric suffix in EnumGen, so distinct case names are no longer required here. |
Member
There was a problem hiding this comment.
[nit] This is leaving a comment on a removed line of code, which would confuse future readers of this codebase.
Suggested change
| // Colliding normalized names (e.g. "beetle one"/"beetle_one") are disambiguated | |
| // with a numeric suffix in EnumGen, so distinct case names are no longer required here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #148