[com.influxdata.telegraf] Add a few input plugins#196
Conversation
HT154
left a comment
There was a problem hiding this comment.
Thanks! Just one issue in the redis input.
RE: your questions:
- I have no objection to this being one PR; it's of a reasonable size and complexity to review in one go.
- These should be closed modules. I'm not 100% sure why some of the existing ones are
open, but it's likely historical (and would be a breaking change to fix).
| /// The command to send to the Redis server, given as the command name | ||
| /// followed by its arguments. | ||
| /// | ||
| /// For example, `new { "get"; "sample-key" }`. | ||
| command: Listing<String>? | ||
|
|
||
| /// The field to store the result in. | ||
| field: String? | ||
|
|
||
| /// The type of the result. | ||
| type: "string" | "integer" | "float" | Null |
There was a problem hiding this comment.
Reading the plugin source, it appears that all of these properties are actually required:
| /// The command to send to the Redis server, given as the command name | |
| /// followed by its arguments. | |
| /// | |
| /// For example, `new { "get"; "sample-key" }`. | |
| command: Listing<String>? | |
| /// The field to store the result in. | |
| field: String? | |
| /// The type of the result. | |
| type: "string" | "integer" | "float" | Null | |
| /// The command to send to the Redis server, given as the command name | |
| /// followed by its arguments. | |
| /// | |
| /// For example, `new { "get"; "sample-key" }`. | |
| command: Listing<String> | |
| /// The field to store the result in. | |
| field: String | |
| /// The type of the result. | |
| type: "string" | "integer" | "float" |
* diskio * kernel * mem * processes * redis * swap * system
|
Thank you for the review, I updated the PR. One question I had that I forgot to ask : for properties such as |
|
Yeah, it makes sense to use what's available in the stdlib rather than |
bioball
left a comment
There was a problem hiding this comment.
LGTM, this is great, thank you!
Hi!
This is pull request that adds a few of the simpler input plugins for Telegraf.
I'm on the fence about two things :
open modulesand some were closed. I decided toopenthose that were non-trivial to let the user add configurations that could be out of sync. Maybe I shouldopenall of them instead?Thank you