Update buildkit v0.27.1#57
Conversation
|
I split the changes so the first commit is only the required changes and the second commit should be derivable from the first commit (since it bumps a bunch of the vendored packages) |
| golang.org/x/sync v0.14.0 | ||
| google.golang.org/grpc v1.72.2 | ||
| google.golang.org/protobuf v1.36.6 | ||
| github.com/tonistiigi/go-csvvalue v0.0.0-20240814133006-030d3b2625d0 |
There was a problem hiding this comment.
Curious why this is a direct dep now?
There was a problem hiding this comment.
not exactly sure why it wasn't there before but it's used in this package
container-builder-shim/pkg/build/build.go
Line 34 in 3fceca1
i'm guessing it might be due to updating go?
There was a problem hiding this comment.
oh i think it's cause i ran go mod tidy
|
Sorry for the delay here, this looks good to me besides the one question |
c51fe98 to
0ee7988
Compare
|
Updated again for v0.27.1 Commands I ran to get the second commit |
|
@Ninja3047 Thank you for the contribution, but the maintainer team will take care of
Thanks! That helps a lot - I applied your non-vendor changes to my tree and got the same result from the steps. |
|
@Ninja3047 we can't merge this until you configure commit signing and sign the commits. See https://github.com/apple/containerization/blob/main/CONTRIBUTING.md#pull-requests for details. |
0ee7988 to
0ff8e74
Compare
Whoops, should be good now |
Closes: apple/container#202