refactor(tui): give the workspace one motion clock, with the effort rail its first user - #44
Merged
Merged
Conversation
…ail its first user The effort rail owned its own 67 ms deadline, and the activity line was about to need a second. The clock now belongs to the workspace: one deadline, each moving thing answering only whether it is visible, and the phase held at the top of view state where any renderer reads it. The effort rail moves exactly as before. MOT-1 to MOT-3 leave stage 34's plan for a motion spec, because code now cites them; EFF-4 and FR-1 point at it instead of naming a clock of their own.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Stage 34, slice 3: the workspace gets one motion clock.
The effort rail owned its own 67 ms deadline, and the activity line was about to need a second. The clock now belongs to the workspace: one deadline, each moving thing answering only whether it is visible, the phase held at the top of view state where any renderer reads it. The effort rail moves exactly as before, and an idle workspace still wakes for nothing.
MOT-1 to MOT-3 move from stage 34's plan into a new
motionspec, because code now cites them; EFF-4 and FR-1 point at it instead of naming a clock of their own. MOT-2 stays marked unproven until the activity line moves.Verified
Local: workspace tests 1618 passed (unsandboxed), clippy
-D warnings, fmt, the pre-commit gates, andscripts/smoke-tui.py. No frame changed. CI not yet observed.