perf(query-planner): reduce allocations and hash-based node comparison in query planner#9803
Open
tninesling wants to merge 6 commits into
Open
perf(query-planner): reduce allocations and hash-based node comparison in query planner#9803tninesling wants to merge 6 commits into
tninesling wants to merge 6 commits into
Conversation
…uery planner Add a precomputed `merge_key_hash` (u64) on each node for fast-reject in `can_merge_sibling_in` and `can_merge_grandchild_in`, avoiding deep Vec<FetchDataPathElement> equality when hashes differ. Convert `subgraph_and_merge_at_key` from string formatting to numeric hash. Additional allocation savings: - `.iter()` instead of `.clone().into_iter()` on `possible_types` - `.copied()` instead of `.cloned()` on Copy-type NodeIndex - Move owned Vec<PlanNode> instead of cloning in flat_wrap_nodes Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: f104ffe466ae96d5b02f0d72 ✅ AI Style Review — No Changes DetectedNo MDX files were changed in this pull request. Review Log: View detailed log
|
Contributor
|
@tninesling, please consider creating a changeset entry in |
The merge key comparison was incorrect and could occasionally prevent merging nodes
TylerBloom
reviewed
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node comparisons:
can_merge_sibling_in, this change compares hashes of the nodes instead of a deep data comparison. Note that this does not affect the check for merging grandchild nodes, as that caused the planner to miss merge opportunities in a previous commitAllocation savings:
subgraph_and_merge_at_keyfrom string formatting to numeric hash.iter()instead of.clone().into_iter()onpossible_types.copied()instead of.cloned()on Copy-type NodeIndexChecklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
A lot of (if not most) features benefit from built-in observability and
debug-level logs. Please read this guidance on metrics best-practices. ↩Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩