ci: pin setup-apify-cli-action to v1.0.0#1880
Merged
Merged
Conversation
Pin the action to an exact version instead of the floating v1 tag so scheduled e2e runs are reproducible and aren't broken by upstream changes.
vdusek
added
t-tooling
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1880 +/- ##
==========================================
+ Coverage 92.63% 92.65% +0.01%
==========================================
Files 161 161
Lines 11323 11323
==========================================
+ Hits 10489 10491 +2
+ Misses 834 832 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vdusek
added a commit
that referenced
this pull request
May 8, 2026
## Summary The scheduled e2e template tests have been failing on every matrix job since #1874 / #1880 adopted `apify/setup-apify-cli-action@v1.0.0`. The action installs apify-cli via a `mise` shim that resolves the apify version by walking up from cwd looking for a `mise.toml`. Our tests run `subprocess.run(['apify', ...], cwd=tmp_path / actor_name)` from pytest's default `tmp_path` (`/tmp/pytest-of-runner/...`), which is outside `MISE_TRUSTED_CONFIG_PATHS` and contains no mise config. The shim therefore errors with `No version is set for shim: apify`. This mirrors how `apify/crawlee` handles the same situation in `test/e2e/tools.mjs` (running `apify push` from a directory under the project root and setting `GIT_CEILING_DIRECTORIES`). ## Changes - `pyproject.toml`: pass `--basetemp=./.pytest-tmp` to the `e2e-templates-tests` poe task so pytest's `tmp_path` lives under the project root, where `mise`'s parent traversal finds the `mise.toml` written by `jdx/mise-action` to `$GITHUB_WORKSPACE`. - `.gitignore`: ignore `.pytest-tmp`. - `tests/e2e/project_template/test_static_crawlers_templates.py`: set `GIT_CEILING_DIRECTORIES=tmp_path` on the `apify push` call so git stops before reaching the project's `.git/`. Failing run: https://github.com/apify/crawlee-python/actions/runs/25541426007
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Floating tag v1 does not work, using the full version instead.