[YUNIKORN-3292] move to pnpm 11 for web UI build#275
Conversation
Change pnpm version to 11 in all files. Move "pnpm" and the overrides from package.json to the pnpm-workspace.yaml file. Block post install scripts for all dependencies. Clean up pnpm-lock.yaml. Fix install of pnpm version in Dockerfile and local build script Move to the latest node 24 release.
wilfred-s
requested review from
brandboat,
chia7712,
craigcondit,
lixmgl,
manirajv06,
mitdesai,
pbacsko and
steinsgateted
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #275 +/- ##
=======================================
Coverage 41.66% 41.66%
=======================================
Files 61 61
Lines 2328 2328
Branches 383 383
=======================================
Hits 970 970
Misses 1165 1165
Partials 193 193 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| "version": "0.0.0", | ||
| "private": true, | ||
| "engines": { | ||
| "node": ">=20.20.0", |
There was a problem hiding this comment.
shall we update node version here as well?
There was a problem hiding this comment.
Angular has a minimum of node 20.19, that is what it is based on. We could have left it at that in the last change but we chose 10.20 for some reason.
| @@ -0,0 +1,13 @@ | |||
| allowBuilds: | |||
| '@parcel/watcher': false | |||
There was a problem hiding this comment.
what does this section do?
There was a problem hiding this comment.
It blocks post install scripts from running. A security measure added in pnpm 11 to fail by default if any package has a post install script and it is not explicitly allowed or blocked. We do not need the post install scripts so they get blocked.
adityadtu5
left a comment
adityadtu5
left a comment
There was a problem hiding this comment.
Some small questions and comments.
Overall looks good
4 participants
What is this PR for?
Change pnpm version to 11 in all files. Move "pnpm" and the overrides from package.json to the pnpm-workspace.yaml file. Block post install scripts for all dependencies. Clean up pnpm-lock.yaml.
Fix install of pnpm version in Dockerfile and local build script Move to the latest node 24 release.
What type of PR is it?
What is the Jira issue?
How should this be tested?
no functional changes, build must pass as do all tests