Skip to content

Fix go.mod to point to soak-test branch, and fix some compilation issues#188

Open
shravan-achar wants to merge 1 commit into
apache:soak-testfrom
shravan-achar:soak-test
Open

Fix go.mod to point to soak-test branch, and fix some compilation issues#188
shravan-achar wants to merge 1 commit into
apache:soak-testfrom
shravan-achar:soak-test

Conversation

@shravan-achar

@shravan-achar shravan-achar commented Feb 18, 2025

Copy link
Copy Markdown

What is this PR for?

Minor bug fixes

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@pbacsko

pbacsko commented Mar 3, 2025

Copy link
Copy Markdown
Contributor

@shravan-achar is this change reviewable? Please update the PR template accordingly (some description, JIRA link).

Comment thread go.mod
)

replace (
github.com/apache/yunikorn-release => github.com/apache/yunikorn-release v1.1.0-1.0.20250213044724-3a0499434067

@pbacsko pbacsko Mar 3, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use a proper master version?
Or is it just a test?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far we are looking to merge all PRs into a branch and then later commit those into master branch. Added this to point to a particular branch (soak-test)

@shravan-achar

Copy link
Copy Markdown
Author

@shravan-achar is this change reviewable? Please update the PR template accordingly (some description, JIRA link).

Not ready yet. Will update shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants