Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions pkg/events/event_system.go
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,10 @@ func (ec *EventSystemImpl) Stop() {

// AddEvent adds an event record to the event system. See the interface for details.
func (ec *EventSystemImpl) AddEvent(event *si.EventRecord) {
if event != nil {
event.Message = truncateEventMessage(event.Message)
}

metrics.GetEventMetrics().IncEventsCreated()
select {
case ec.channel <- event:
Expand All @@ -232,6 +236,15 @@ func (ec *EventSystemImpl) AddEvent(event *si.EventRecord) {
}
}

// truncates event message to 1024 characters for k8s compatibility
func truncateEventMessage(message string) string {
const k8sEventMessageLimit = 1024
if len(message) <= k8sEventMessageLimit {
return message
}
return message[:k8sEventMessageLimit-3] + "..."
}

func isTrackingEnabled() bool {
return common.GetConfigurationBool(configs.GetConfigMap(), configs.CMEventTrackingEnabled, configs.DefaultEventTrackingEnabled)
}
Expand Down
36 changes: 36 additions & 0 deletions pkg/events/event_system_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ package events

import (
"strconv"
"strings"
"testing"
"time"

Expand Down Expand Up @@ -205,3 +206,38 @@ func TestRingBufferCapacity(t *testing.T) {
capacity = getRingBufferCapacity()
assert.Equal(t, uint64(configs.DefaultEventRingBufferCapacity), capacity)
}

func TestTruncateEventMessage(t *testing.T) {
testCases := []struct {
name string
message string
expected string
}{
{
name: "message length less than 1024 characters",
message: getTestString(10),
expected: getTestString(10),
},
{
name: "message length exactly 1024 characters",
message: getTestString(1024),
expected: getTestString(1024),
},
{
name: "message length greater than 1024 characters",
message: getTestString(1100),
expected: getTestString(1024-3) + "...",
},
}

for _, testCase := range testCases {
t.Run(testCase.name, func(t *testing.T) {
truncated := truncateEventMessage(testCase.message)
assert.Equal(t, testCase.expected, truncated)
})
}
}

func getTestString(stringLength int) string {
return strings.Repeat("x", stringLength)
}