[YUNIKORN-3092] Reservations can permanently block nodes, leading to …#1025
Closed
manirajv06 wants to merge 3 commits into
Closed
[YUNIKORN-3092] Reservations can permanently block nodes, leading to …#1025manirajv06 wants to merge 3 commits into
manirajv06 wants to merge 3 commits into
Conversation
…preemption failure and a stuck scheduler state
manirajv06
requested review from
craigcondit,
pbacsko,
wilfred-s and
yangwwei
and removed request for
wilfred-s
July 7, 2025 17:26
…r priority 3. Not exceeds waiting time 4. Exceeds waiting time
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1025 +/- ##
==========================================
+ Coverage 82.68% 82.74% +0.05%
==========================================
Files 98 98
Lines 15690 15719 +29
==========================================
+ Hits 12973 13006 +33
+ Misses 2441 2438 -3
+ Partials 276 275 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jdaciuk
reviewed
Jul 10, 2025
jdaciuk
left a comment
jdaciuk
left a comment
There was a problem hiding this comment.
@manirajv06 Thanks for taking up this issue and this LGTM. Looking forward to upgrading to the eventual release.
Personally we'd like to also cancel reservations of equal priority, but I understand that wouldn't appeal to everyone. Left some more thoughts in the JIRA ticket since they are less relevant to this code.
pbacsko
requested changes
Jul 10, 2025
…setup methods 2. Removed the option to set reservation wait timeout
pbacsko
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…preemption failure and a stuck scheduler state
What is this PR for?
Consider even the nodes which has non daemon set reservations and reservation (allocation) not triggered preemption earlier as candidate to increase the chances of preemption. But cancel those reservations only if its priority is lesser than the preemptor priority and waiting in reservation for more than 1 hour.
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-3092
How should this be tested?
Screenshots (if appropriate)
Questions: