Repository navigation
feat(workflow-operator): volcano plot labels follow columns - #9040
Open
eugenegujing wants to merge 1 commit into
Open
eugenegujing wants to merge 1 commit into
eugenegujing wants to merge 1 commit into
Conversation
Name the y column and its axis -log10(<p-value column>) instead of the fixed "-log10(pvalue)". Add optional Title, X Label, Y Label and Color Bar Label properties that override the column-derived text when set; an empty or blank field keeps the default.
Contributor
Automated Reviewer SuggestionsBased on the
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Root cause:
VolcanoPlotOpDesc.generatePythonCodehard-codes the y column as the literal"-log10(pvalue)"and plots it under that name, so the y axis always says-log10(pvalue)even when the selected column ispadj. The title is the literal"Volcano Plot"and the x axis and color bar show the raw effect column name. None of this can be changed from the property panel.The y column is now named after the selected p-value column, so the axis and the hover text say which column was transformed. Four optional label properties are added, empty by default:
Volcano Plot-log10(<p-value column>)The labels go through
fig.update_layout(xaxis_title, yaxis_title, coloraxis_colorbar_title_text), same as Line Chart's X Label / Y Label. Each label is anEncodableString, so quotes and non-ASCII text are fine. A whitespace-only field counts as empty. The hover box still shows raw column names (plotly behaviour, same as Line Chart).Behavior change for saved workflows: a workflow with
padjas the p-value column now renders-log10(padj)instead of-log10(pvalue). That is the fix.Rebase note:
coloraxis_colorbar_title_textis emitted unconditionally. Once the significance-coloring PR (#9039) lands, the categorical mode has nocoloraxis, so whichever branch rebases second needs to make that entry conditional.Figures below are the operator's generated Python from
mainand from this branch, run on the 430-gene example workflow from the issue; the third one has all four labels filled in.Any related issues, documentation, discussions?
Closes #9037
PR #8504 adds a
generateStandaloneCode()path to this operator that copies the current template, including the hard-coded"-log10(pvalue)". Whichever lands first, the other needs a follow-up.How was this PR tested?
New tests in
VolcanoPlotOpDescSpec, written before the source change:Smoke run: the generated code was executed outside Texera (pytexera stubbed, pandas + plotly 5.24.1) on the 430-gene mock table. Defaults give title
Volcano Plot, xlfc_shrunk, y-log10(padj), color barlfc_shrunk; with all four labels set the figure shows the typed text; whitespace-only title and y label fall back to the defaults.Was this PR authored or co-authored using generative AI tooling?
Yes. Generated-by: Claude Code (claude-fable-5-1). Co-authored with Claude; the author reviewed the change before submission.