Repository navigation
Conversation
… and signed zero The export called drop_duplicates, which counts two NaN values as equal and 0.0 as equal to -0.0. The engine's LinkedHashSet compares rows with Scala's ==, under which NaN equals nothing, and hashes doubles by their bits, so it keeps all of them. Select rows by the key the set operators already use. Closes apache#8974 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Automated Reviewer SuggestionsBased on the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8975 +/- ##
============================================
- Coverage 92.61% 92.61% -0.01%
+ Complexity 5059 5058 -1
============================================
Files 1258 1258
Lines 53780 53779 -1
Branches 6707 6707
============================================
- Hits 49811 49810 -1
Misses 2313 2313
Partials 1656 1656
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
📊 Arrow Flight E2E bench(no arrow-flight-e2e.csv in artifact) |
13 of 31 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Distinct's exported Python called
drop_duplicates, which counts two NaN values as equal and 0.0 as equal to -0.0. The engine'sDistinctOpExeckeeps rows in aLinkedHashSetthat compares them with Scala's==, under which NaN equals nothing, and hashes each double by its bits, so 0.0 and -0.0 land apart. The export therefore emitted fewer rows than the run it came from.The export now selects rows with
_texera_set_select, the helper the set operators use: one key per row, equal exactly where the engine's rows are, keeping the first row of each key in input order.Any related issues, documentation, discussions?
Closes #8974. Depends on #8506, which adds
StandaloneHelpers.SetRowKeys; until it merges this branch does not compile.How was this PR tested?
DistinctOpDescSpecgains a test that runsDistinctOpExecand the exported Python over 1.0, NaN, 0.0, -0.0, null, 1.0, NaN, null, -0.0 and compares the rows in order. The engine keeps 6. The old export kept 4 and fails the test. It replaces the test that pinned the olddrop_duplicatesline. With #8506 applied, all 11 Distinct tests pass, and Distinct's verification run still matches.Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5.5)
🤖 Generated with Claude Code