Skip to content

feat(i18n): wrap description strings in translation function#41626

Merged
hainenber merged 2 commits into
apache:masterfrom
imad-hl:feat/i18n-frontend-translations
Jul 2, 2026
Merged

feat(i18n): wrap description strings in translation function#41626
hainenber merged 2 commits into
apache:masterfrom
imad-hl:feat/i18n-frontend-translations

Conversation

@imad-hl

@imad-hl imad-hl commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

SUMMARY

Wrap hardcoded description strings with i18n translation function (t()) to enable internationalization for the following components:

  • Cartodiagram plugin: chart description
  • BigNumber PeriodOverPeriod plugin: chart description
  • SavedQueryList: search filter tooltip description
  • Tags page: empty state description

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot Bot added change:frontend Requires changing the frontend i18n Namespace | Anything related to localization labels Jul 1, 2026
@bito-code-review

bito-code-review Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Bito Review Skipped - Source Branch Not Found

Bito didn’t review this change because the pull request is no longer valid. It may have been merged, or the source/target branch may no longer exist.

@netlify

netlify Bot commented Jul 1, 2026

Copy link
Copy Markdown

Deploy Preview for superset-docs-preview ready!

Name Link
🔨 Latest commit 6e29c6a
🔍 Latest deploy log https://app.netlify.com/projects/superset-docs-preview/deploys/6a4536fd0626a1000837cd3e
😎 Deploy Preview https://deploy-preview-41626--superset-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added plugins and removed i18n Namespace | Anything related to localization labels Jul 1, 2026
Wrap hardcoded description strings with i18n translation function (t())
to enable internationalization for the following components:

- Cartodiagram plugin: chart description
- BigNumber PeriodOverPeriod plugin: chart description
- SavedQueryList: search filter tooltip description
- Tags page: empty state description
@imad-hl
imad-hl force-pushed the feat/i18n-frontend-translations branch from 4ae3491 to 6e29c6a Compare July 1, 2026 15:49
@sadpandajoe
sadpandajoe requested a review from rusackas July 1, 2026 17:32
@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.65%. Comparing base (692f81d) to head (82d725f).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #41626      +/-   ##
==========================================
- Coverage   63.86%   63.65%   -0.22%     
==========================================
  Files        2670     2670              
  Lines      147343   147343              
  Branches    33988    33988              
==========================================
- Hits        94105    93794     -311     
- Misses      51509    51830     +321     
+ Partials     1729     1719      -10     
Flag Coverage Δ
javascript 69.15% <ø> (-0.01%) ⬇️
postgres ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hainenber hainenber left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution

@hainenber
hainenber merged commit 4c193d4 into apache:master Jul 2, 2026
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:frontend Requires changing the frontend plugins size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants