Skip to content

fix(a11y): add aria-label to cross-filter search icon #41619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eschutho merged 2 commits into from
Jul 13, 2026
+10 −0
Merged

fix(a11y): add aria-label to cross-filter search icon #41619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
244dcc6
fix(a11y): add aria-label to cross-filter search icon
eschutho Jul 1, 2026
a65a800
test(a11y): assert accessible name on cross-filter search icon
eschutho Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ...d/src/dashboard/components/nativeFilters/FilterBar/CrossFilters/CrossFilterTitle.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,3 +70,12 @@ test('Search icon should highlight emitter', async () => {
expect(mockedProps.onHighlightFilterSource).toHaveBeenCalled();
});
});

test('Search icon should have an accessible name', async () => {
setup(mockedProps);
await waitFor(() => {
expect(
screen.getByRole('button', { name: 'Locate the chart' }),
).toBeInTheDocument();
});
});
1 change: 1 addition & 0 deletions ...ontend/src/dashboard/components/nativeFilters/FilterBar/CrossFilters/CrossFilterTitle.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ const CrossFilterChartTitle = (props: {
data-test="cross-filters-highlight-emitter"
role="button"
tabIndex={0}
aria-label={t('Locate the chart')}
onClick={onHighlightFilterSource}
/>
</Tooltip>
Expand Down
Loading