fix(calendar): clean up d3-tip tooltips#41589
Draft
sadpandajoe wants to merge 6 commits into
Draft
Conversation
sadpandajoe
force-pushed
the
fix-calendar-heatmap-tooltip-cleanup-41583
branch
from
July 1, 2026 17:20
8ef8473 to
6b01947
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #41589 +/- ##
==========================================
+ Coverage 64.44% 65.40% +0.96%
==========================================
Files 2751 2695 -56
Lines 154313 149770 -4543
Branches 35362 34727 -635
==========================================
- Hits 99440 97955 -1485
+ Misses 52962 50049 -2913
+ Partials 1911 1766 -145
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sadpandajoe
force-pushed
the
fix-calendar-heatmap-tooltip-cleanup-41583
branch
from
July 3, 2026 14:10
7c13a86 to
06f49e4
Compare
Member
|
This one looks pretty well buttoned up. Anything keeping it in draft? Happy to take a proper review pass whenever you flip it to mergeable. |
sadpandajoe
force-pushed
the
fix-calendar-heatmap-tooltip-cleanup-41583
branch
from
July 7, 2026 14:11
06f49e4 to
8d4dfba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(calendar): clean up d3-tip tooltips
SUMMARY
Fixes #41583
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Not applicable; tooltip cleanup is covered by DOM-level regression tests.
TESTING INSTRUCTIONS
cd superset-frontend && NODE_ENV=test NODE_OPTIONS='--max-old-space-size=8192' npx jest --runInBand --silent plugins/legacy-plugin-chart-calendar/test/tooltip.test.ts plugins/legacy-plugin-chart-calendar/test/utils.test.tscd superset-frontend && npx oxlint --config oxlint.json plugins/legacy-plugin-chart-calendar/src/Calendar.ts plugins/legacy-plugin-chart-calendar/src/ReactCalendar.tsx plugins/legacy-plugin-chart-calendar/src/tooltip.ts plugins/legacy-plugin-chart-calendar/src/vendor/cal-heatmap.ts plugins/legacy-plugin-chart-calendar/test/tooltip.test.tsADDITIONAL INFORMATION