Skip to content

fix(i18n): update German security menu translations#41587

Merged
hainenber merged 4 commits into
apache:masterfrom
brianmmaina:fix/german-security-menu-translations
Jul 2, 2026
Merged

fix(i18n): update German security menu translations#41587
hainenber merged 4 commits into
apache:masterfrom
brianmmaina:fix/german-security-menu-translations

Conversation

@brianmmaina

@brianmmaina brianmmaina commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

SUMMARY

Fixes incorrect German translations for security menu items.

Updates:

  • List Groups → Gruppen auflisten
  • List Roles → Rollen auflisten
  • List Users → Benutzer*innen auflisten

Note: Themes is already translated correctly as Designs on current master, so this PR only updates the remaining list labels.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Not included. This is a translation-only change.

TESTING INSTRUCTIONS

Verified the updated entries in superset/translations/de/LC_MESSAGES/messages.po.

ADDITIONAL INFORMATION

@dosubot dosubot Bot added the i18n:german Translation related to German language label Jun 30, 2026
@bito-code-review

bito-code-review Bot commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Code Review Agent Run #4df3f4

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: 9f4fc64..9f4fc64
    • superset/translations/de/LC_MESSAGES/messages.po
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@github-actions github-actions Bot added the i18n Namespace | Anything related to localization label Jun 30, 2026
@sadpandajoe sadpandajoe added the review:checkpoint Last PR reviewed during the daily review standup label Jun 30, 2026
@codecov

codecov Bot commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.59%. Comparing base (0a25faa) to head (892c0c2).
⚠️ Report is 9 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #41587      +/-   ##
==========================================
- Coverage   64.60%   64.59%   -0.01%     
==========================================
  Files        2684     2684              
  Lines      148199   148267      +68     
  Branches    34140    34150      +10     
==========================================
+ Hits        95747    95778      +31     
- Misses      50711    50744      +33     
- Partials     1741     1745       +4
Flag Coverage Δ
hive 39.23% <ø> (+<0.01%) ⬆️
mysql 57.83% <ø> (-0.02%) ⬇️
postgres 57.89% <ø> (-0.02%) ⬇️
presto 40.76% <ø> (+<0.01%) ⬆️
python 59.28% <ø> (-0.02%) ⬇️
sqlite 57.47% <ø> (-0.02%) ⬇️
unit 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

hainenber
hainenber reviewed Jun 30, 2026
View reviewed changes
Comment thread superset/translations/de/LC_MESSAGES/messages.po
@bito-code-review

bito-code-review Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

You are correct. In German, the umlaut (ä, ö, ü) is used to modify vowels, whereas the asterisk (*) is not a standard character in German orthography. If the asterisk was used in the translation file, it is likely a placeholder or a formatting error that should be corrected.

@netlify

netlify Bot commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for superset-docs-preview ready!

Name Link
🔨 Latest commit ec90973
🔍 Latest deploy log https://app.netlify.com/projects/superset-docs-preview/deploys/6a467ae666f98300080b8cf9
😎 Deploy Preview https://deploy-preview-41587--superset-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@brianmmaina
brianmmaina requested a review from hainenber June 30, 2026 21:57
@bito-code-review

bito-code-review Bot commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Code Review Agent Run #4b9637

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: 9f4fc64..5a53a1f
    • superset/translations/de/LC_MESSAGES/messages.po
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

⚠️ Translation Regression Detected

A source change in this PR renamed or reworded strings, invalidating existing translations (they are now #, fuzzy) in fi, th. Please resolve the affected .po files before merging.

Note: intentionally deleting a translatable string is not a regression and is not flagged here — only translations invalidated by a renamed/reworded source string are.

Language Fuzzy before Fuzzy after New
fi 4808 4809 +1
th 4808 4809 +1

How to fix

1. Install dependencies (if not already set up):

pip install -r superset/translations/requirements.txt
sudo apt-get install gettext   # or: brew install gettext

2. Re-extract strings and sync .po files:

./scripts/translations/babel_update.sh

This rewrites superset/translations/messages.pot from the current source files and merges the changes into every .po file. Strings whose msgid changed will be marked #, fuzzy.

3. Resolve the fuzzy entries in the affected language files (fi, th):

grep -n '#, fuzzy' superset/translations/<lang>/LC_MESSAGES/messages.po

For each fuzzy entry, either rewrite the msgstr to match the new string and remove the #, fuzzy line, or clear the msgstr to "" if you cannot provide a translation.

4. Commit your changes to the .po files.

@sadpandajoe sadpandajoe removed the review:checkpoint Last PR reviewed during the daily review standup label Jul 1, 2026
@bito-code-review

bito-code-review Bot commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Code Review Agent Run #9df2dd

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: 5a53a1f..892c0c2
    • superset/translations/de/LC_MESSAGES/messages.po
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@hainenber

hainenber commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Thanks @brianmmaina and all for the work plus discussion!

@hainenber
hainenber merged commit 139df20 into apache:master Jul 2, 2026
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hainenber hainenber hainenber approved these changes
@sfirke sfirke Awaiting requested review from sfirke sfirke is a code owner
@rusackas rusackas Awaiting requested review from rusackas rusackas is a code owner
@villebro villebro Awaiting requested review from villebro villebro is a code owner
@sadpandajoe sadpandajoe Awaiting requested review from sadpandajoe sadpandajoe is a code owner
+2 more reviewers
@timitos timitos timitos left review comments
@semohr semohr semohr left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

i18n:german Translation related to German language i18n Namespace | Anything related to localization size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: German (de) translations contain wrong/empty strings for security menu items

5 participants

@brianmmaina @hainenber @timitos @semohr @sadpandajoe