fix(plugin-chart-echarts): prevent trendline stroke clipping at chart edges by mistercrunch · Pull Request #37918 · apache/superset

mistercrunch · 2026-02-12T00:26:30Z

SUMMARY

The Big Number with Trendline chart clips/truncates the line stroke at the edges of the viewport (especially at X=0). This happens because when axes are hidden, the ECharts grid is set to zero padding on all sides. Since the line stroke extends beyond the data point by half its width, pixels at the boundary get cut off.

This fix:

Explicitly sets lineStyle.width on the trendline series (was previously relying on ECharts default)
Adds strokeWidth / 2 padding to the grid on all sides when axes are hidden, so the full stroke is visible

The padding is derived from the line width rather than hardcoded, so it scales correctly if the stroke width changes.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before: Trendline stroke is truncated at the left edge (X=0) by ~1px
After: Full stroke is visible with minimal padding that accommodates the stroke width

TESTING INSTRUCTIONS

Create a Big Number with Trendline chart
Ensure "Show X Axis" and "Show Y Axis" are both unchecked (default)
Observe that the trendline stroke is no longer clipped at the left/right/top/bottom edges
Enable either axis and verify the chart still uses the standard TIMESERIES_CONSTANTS grid offsets

ADDITIONAL INFORMATION

Has associated issue: Fixes [cosmetic] Big Number with Trendline viewport truncates stroke where X=0 #33454
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

bito-code-review · 2026-02-12T00:26:40Z

Code Review Agent Run #3d4613

Actionable Suggestions - 0

Review Details

Files reviewed - 2 · Commit Range: f14114b..f14114b
- superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberWithTrendline/transformProps.ts
- superset-frontend/plugins/plugin-chart-echarts/test/BigNumber/transformProps.test.ts
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
- Eslint (Linter) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

bito-code-review · 2026-02-12T03:03:45Z

Code Review Agent Run #6ac3b5

Actionable Suggestions - 0

Review Details

Files reviewed - 2 · Commit Range: 0a64ec2..0a64ec2
- superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberWithTrendline/transformProps.ts
- superset-frontend/plugins/plugin-chart-echarts/test/BigNumber/transformProps.test.ts
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
- Eslint (Linter) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

… edges The BigNumber with Trendline chart was clipping the line stroke at the edges (especially X=0) because the ECharts grid had zero padding when axes were hidden. The stroke extends beyond the data point by half its width, so pixels at the boundary were truncated by the viewport. Add half-strokeWidth padding to the grid on all sides when axes are hidden, and explicitly set lineStyle.width so the padding stays in sync with the actual stroke size. Fixes #33454 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

bito-code-review · 2026-02-12T16:24:09Z

Code Review Agent Run #a030e8

Actionable Suggestions - 0

Review Details

Files reviewed - 2 · Commit Range: 12e1917..12e1917
- superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberWithTrendline/transformProps.ts
- superset-frontend/plugins/plugin-chart-echarts/test/BigNumber/transformProps.test.ts
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
- Eslint (Linter) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

github-actions · 2026-02-24T22:33:32Z

🎪 Showtime is building environment on GHA for 12e1917

github-actions · 2026-02-24T22:52:05Z

🎪 Showtime deployed environment on GHA for 12e1917

• Environment: http://16.148.73.141:8080 (admin/admin)
• Lifetime: 48h auto-cleanup
• Updates: New commits create fresh environments automatically

EnxDev · 2026-02-24T23:15:49Z

From manual testing, I see that a scroll bar has appeared.

after.mov

bito-code-review · 2026-06-30T15:56:15Z

Code Review Agent Run #1ae351

Actionable Suggestions - 0

Review Details

Files reviewed - 2 · Commit Range: 12e1917..d42d6c8
- superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberWithTrendline/transformProps.ts
- superset-frontend/plugins/plugin-chart-echarts/test/BigNumber/transformProps.test.ts
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
- Eslint (Linter) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

github-actions · 2026-07-01T05:33:19Z

🎪 Showtime is building environment on GHA for 44a0738

github-actions · 2026-07-01T05:50:50Z

🎪 Showtime deployed environment on GHA for 44a0738

• Environment: http://35.89.211.85:8080 (admin/admin)
• Lifetime: 48h auto-cleanup
• Updates: New commits create fresh environments automatically

codecov · 2026-07-01T17:50:11Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.45%. Comparing base (692f81d) to head (7674163).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff            @@
##           master   #37918    +/-   ##
========================================
  Coverage   64.45%   64.45%            
========================================
  Files        2670     2670            
  Lines      147343   147201   -142     
  Branches    33988    33953    -35     
========================================
- Hits        94966    94882    -84     
+ Misses      50650    50610    -40     
+ Partials     1727     1709    -18

Flag	Coverage Δ
javascript	`69.14% <100.00%> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pull-request-size Bot added the size/S label Feb 12, 2026

github-actions Bot added the plugins label Feb 12, 2026

mistercrunch force-pushed the fix-bignumber-trendline-stroke branch from f14114b to 0a64ec2 Compare February 12, 2026 01:57

mistercrunch force-pushed the fix-bignumber-trendline-stroke branch from 0a64ec2 to 12e1917 Compare February 12, 2026 15:18

rusackas mentioned this pull request Feb 22, 2026

[cosmetic] Big Number with Trendline viewport truncates stroke where X=0 #33454

Closed

rusackas requested review from EnxDev and rusackas February 24, 2026 18:22

EnxDev added the 🎪 ⚡ showtime-trigger-start Create new ephemeral environment for this PR label Feb 24, 2026

github-actions Bot added 🎪 12e1917 🚦 building 🎪 ⌛ 48h Environment expires after 48 hours (default) and removed 🎪 ⚡ showtime-trigger-start Create new ephemeral environment for this PR labels Feb 24, 2026

github-actions Bot added 🎪 12e1917 🚦 deploying and removed 🎪 12e1917 🚦 building labels Feb 24, 2026

github-actions Bot removed the 🎪 12e1917 📅 2026-02-24T22-33 label Feb 27, 2026

Merge branch 'master' into fix-bignumber-trendline-stroke

44a0738

pull-request-size Bot added size/M and removed size/S labels Jul 1, 2026

rusackas added merge-if-green If approved and tests are green, please go ahead and merge it for me and removed size/M labels Jul 1, 2026

github-actions Bot added 🎪 44a0738 🚦 building labels Jul 1, 2026

github-actions Bot added 🎪 44a0738 🚦 deploying and removed 🎪 44a0738 🚦 building labels Jul 1, 2026

Merge branch 'master' into fix-bignumber-trendline-stroke

4af6af7

pull-request-size Bot added the size/M label Jul 1, 2026

EnxDev removed size/M 🎪 ⌛ 48h Environment expires after 48 hours (default) labels Jul 1, 2026

Merge branch 'master' into fix-bignumber-trendline-stroke

7674163

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(plugin-chart-echarts): prevent trendline stroke clipping at chart edges#37918

fix(plugin-chart-echarts): prevent trendline stroke clipping at chart edges#37918
EnxDev merged 6 commits into
masterfrom
fix-bignumber-trendline-stroke

mistercrunch commented Feb 12, 2026

Uh oh!

bito-code-review Bot commented Feb 12, 2026 •

edited

Loading

Code Review Agent Run #3d4613

Uh oh!

bito-code-review Bot commented Feb 12, 2026 •

edited

Loading

Code Review Agent Run #6ac3b5

Uh oh!

bito-code-review Bot commented Feb 12, 2026 •

edited

Loading

Code Review Agent Run #a030e8

Uh oh!

github-actions Bot commented Feb 24, 2026

Uh oh!

github-actions Bot commented Feb 24, 2026

Uh oh!

EnxDev commented Feb 24, 2026

Uh oh!

bito-code-review Bot commented Jun 30, 2026 •

edited

Loading

Code Review Agent Run #1ae351

Uh oh!

github-actions Bot commented Jul 1, 2026

Uh oh!

github-actions Bot commented Jul 1, 2026

Uh oh!

codecov Bot commented Jul 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

mistercrunch commented Feb 12, 2026

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Uh oh!

bito-code-review Bot commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #3d4613

Uh oh!

bito-code-review Bot commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #6ac3b5

Uh oh!

bito-code-review Bot commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #a030e8

Uh oh!

github-actions Bot commented Feb 24, 2026

Uh oh!

github-actions Bot commented Feb 24, 2026

Uh oh!

EnxDev commented Feb 24, 2026

Uh oh!

bito-code-review Bot commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #1ae351

Uh oh!

github-actions Bot commented Jul 1, 2026

Uh oh!

github-actions Bot commented Jul 1, 2026

Uh oh!

codecov Bot commented Jul 1, 2026

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

bito-code-review Bot commented Feb 12, 2026 •

edited

Loading

bito-code-review Bot commented Feb 12, 2026 •

edited

Loading

bito-code-review Bot commented Feb 12, 2026 •

edited

Loading

bito-code-review Bot commented Jun 30, 2026 •

edited

Loading