build(dev-deps): replace monolithic Lerna with lightweight @lerna-lite#37222
build(dev-deps): replace monolithic Lerna with lightweight @lerna-lite#37222hainenber wants to merge 19 commits into
@lerna-lite#37222Conversation
Signed-off-by: hainenber <dotronghai96@gmail.com>
|
CodeAnt AI is reviewing your PR. Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
Code Review Agent Run #0757c4Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
|
CodeAnt AI finished reviewing your PR. |
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR migrates from the monolithic lerna package to the lightweight, modular @lerna-lite alternative. The migration maintains API compatibility while reducing development dependencies by approximately 100+ packages.
Changes:
- Replaced
lernawith four modular@lerna-lite/*packages (cli, exec, publish, version) - Updated lerna.json configuration to use the @lerna-lite schema and removed the deprecated
graphTypeoption - Improved code formatting in build.js by consolidating a multi-line command string
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| superset-frontend/package.json | Replaced monolithic lerna@^8.2.3 with four modular @lerna-lite/*@^4.11.0 packages (cli, exec, publish, version) |
| superset-frontend/lerna.json | Updated schema path to reference @lerna-lite/cli and removed graphType option from publish command configuration |
| superset-frontend/scripts/build.js | Reformatted babel command from multi-line to single-line string for improved readability |
Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
codeant-ai-for-open-source
Bot
added
the
size:XS
Signed-off-by: hainenber <dotronghai96@gmail.com>
codeant-ai-for-open-source
Bot
added
size:XS
|
@rusackas can this be the interim solution until we can go for Bun/Turborepo/Changeset tooling? 👀 |
codeant-ai-for-open-source
Bot
added
size:L
github-actions
Bot
added
i18n
github-actions
Bot
removed
i18n:french
Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
|
Alright, the commit history is steady now. PTAL when you have time :D |
Code Review Agent Run #cda914Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
rusackas
left a comment
rusackas
left a comment
There was a problem hiding this comment.
Thanks for trimming this back down to the Lerna swap.
Two things left:
• Rebase to resolve conflicts
• webpack.config.js now flips buffer from the dev-only require.resolve('buffer/') to buffer: false. That polyfill was added on purpose to fix the legacy-plugin-chart-paired-t-test Story, and the paired Buffer: ['buffer', 'Buffer'] ProvidePlugin entry just above it is left as-is. Is that change meant to be in the lerna-lite PR? Feels unrelated, and I'd want to confirm the Story still renders before dropping it. One of these days, I'll update that plugin to be non-legacy, or just deprecate the thing!
Signed-off-by: hainenber <dotronghai96@gmail.com>
…book Signed-off-by: hainenber <dotronghai96@gmail.com>
…ybook Signed-off-by: hainenber <dotronghai96@gmail.com>
|
@rusackas PTAL when you have time ;) |
Code Review Agent Run #a89db1Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #37222 +/- ##
=======================================
Coverage 64.70% 64.70%
=======================================
Files 2686 2686
Lines 148626 148626
Branches 34298 34298
=======================================
Hits 96164 96164
Misses 50697 50697
Partials 1765 1765
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: hainenber <dotronghai96@gmail.com>
|
Trimming ~100 transitive dev deps by moving to Also curious whether the stray It's conflicting with master too, so it'll want a rebase. Holler if you want a hand with any of that. |
User description
build(dev-deps): replace monolithic Lerna with lightweight
@lerna-liteSUMMARY
This PR is to replace monorepo tooling Lerna with a lightweight alternative, API-compliant and modular
@lerna-lite/*packages.@lerna-lite/exec@lerna-lite/version@lerna-lite/publishOnce this PR gets merged, there would be a reduction of approximately 100+ dev deps.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Confirm that
npm plugins:create-*commands that utilizeslerna versionin dry modelerna execis executed in CI so expect the CI should be green for acceptance criterion.I might need help with
lerna publishthough.TESTING INSTRUCTIONS
For write access maintainers:
npm run plugins:release-from-tagto test out publishing functionality is still intact.ADDITIONAL INFORMATION
CodeAnt-AI Description
Use lightweight @lerna-lite, improve autogenerated chart names, and fix translated progress messages
What Changed
Impact
✅ Clearer autogenerated chart names for saved charts✅ Smaller developer dependency footprint✅ Accurate "running block" progress messages in multiple locales💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.