WW-5630 Streamline ConfigParseUtilTest and convert to JUnit 4#1740
Merged
Conversation
Collapse 12 overlapping cache tests to 5 focused ones, replace the ~80-entry JDK class-name literal with a synthetic-name loop bounded by the inner-cache limit, and drop reflection from the behavioral tests (load-count assertions only). Reflection is retained solely in the two size-bound tests, where Caffeine exposes no public seam. Production ConfigParseUtil caching logic is unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
2 tasks
lukaszlenart
added a commit
that referenced
this pull request
Jun 14, 2026
…it 4 (#1741) Port of #1740 to 6.x: 12 overlapping cache tests collapsed to 5 focused ones, JUnit 3 -> JUnit 4, dropped the ~80-class literal, reflection kept only in the two size-bound tests. Also reorders the caffeine imports in ConfigParseUtil to match alphabetical ordering. Production logic unchanged. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test-only cleanup of
ConfigParseUtilTest, which was added in #1721 (the class-validation caching introduced for WW-5630). The production caching logic inConfigParseUtilis unchanged — this only improves the test.toString()case, outer-size bound, inner-size bound, and the negative/not-cached case).estimatedSize().@Test/@Before/@Afterwith staticorg.junit.Assert.*, matching the convention of the newest standalone unit tests incore(e.g.ContainerHolderTest,NamedVariablePatternMatcherTest).Net: 90 insertions / 183 deletions, 12 tests → 5.
Fixes WW-5630 test-quality follow-up.
Test Plan
./mvnw -pl core clean test -Dtest=ConfigParseUtilTest→Tests run: 5, Failures: 0, Errors: 0, Skipped: 0./mvnw -pl core apache-rat:check→ BUILD SUCCESS (license headers)core/src/main/java/org/apache/struts2/util/ConfigParseUtil.javaunchanged🤖 Generated with Claude Code